Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(atorch.utils.fsdp_save_util): doc of fsdp shard save #764

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cos120
Copy link

@cos120 cos120 commented Oct 13, 2023

What changes were proposed in this pull request?

Please describe the changes you have made or proposed in this pull request.

Why are the changes needed?

Explain the purpose or motivation behind these changes. What problem are you trying to solve?

Does this PR introduce any user-facing change?

Specify whether this pull request introduces any changes that users will directly interact with or notice.

How was this patch tested?

Detail the testing process you have undertaken to ensure the changes in this pull request are valid and working as intended.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #764 (2418677) into master (5f972b1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #764   +/-   ##
=======================================
  Coverage   75.07%   75.07%           
=======================================
  Files         156      156           
  Lines       13081    13081           
=======================================
  Hits         9820     9820           
  Misses       3261     3261           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@skydoorkai
Copy link
Collaborator

Add English document first.
If Chinese version add, name it fsdp_shard_save_chinese.md, and English version as fsdp_shard_save_en.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants