Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#6404] Server process removes leftover shared memory files on startup (main) #6407

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[#6404] Server process removes leftover shared memory files on startup (main) #6407

wants to merge 1 commit into from

Conversation

korydraughn
Copy link
Collaborator

No description provided.

@trel
Copy link
Member

trel commented May 19, 2022

tweak commit message...

This change will cause the server to remove any files containing "irods"
in their filename.

consider...

This change causes the server to remove any filenames beginning with "irods_".

@korydraughn
Copy link
Collaborator Author

With this PR, we are establishing a convention that any shared memory files needing to be removed on startup must have a filename that starts with irods_.

We'll need to document that in the developer docs.

@korydraughn
[6404] Server process removes leftover shared memory files on startup.
23e6ce9 
This moves the responsibility of shared memory file cleanup from the
startup scripts (i.e. irodsctl, controller.py) to the iRODS server
process.

This change causes the server to remove any shared memory files having
a filename beginning with "irods_".
@trel
Copy link
Member

trel commented May 19, 2022

This will remove all the shm files that match - including ones that might be in use by another iRODS server running on the same machine... (non-package-install)...

So, we're going to hold on this for now to better determine why we are occasionally seeing collisions with these shm files - and solve that more directly, eventually.

@korydraughn korydraughn marked this pull request as draft May 19, 2022 17:07
@alanking alanking mentioned this pull request Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trel trel trel left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@korydraughn @trel