Added single quote escaping to general_query #7237
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potentially scary PR that allows for embedded single quote stuff to be used in genQuery1.
Pros:
Cons:
e.g. of an issue with iput if no fixes are implemented and this change is merged in: any file with double embedded quotes will be treated as if they only had a single quote, and passing it with -f could clobber a file unexpectedly.
With genQuery2 on the horizon, this potentially breaking change is questionably worth merging. However, I will leave it here as a point of discussion or for posterity.
EDIT: Relevant issues appear to be #7169 #7164 (Verified this fix works for the latter, haven't checked the former)