Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add guidelines for adding new features to stable APIs #3182

Merged
merged 1 commit into from
May 22, 2024

Conversation

whitneygriffith
Copy link
Contributor

@whitneygriffith whitneygriffith commented May 8, 2024

Adds guidelines for adding a new feature to a v1 API or adding a new API to ensure that the stable validating admission policy is kept up to date.
Part of 173

@whitneygriffith whitneygriffith requested a review from a team as a code owner May 8, 2024 20:41
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 8, 2024
@whitneygriffith whitneygriffith added the release-notes-none Indicates a PR that does not require release notes. label May 8, 2024
@whitneygriffith
Copy link
Contributor Author

/retest-required

@keithmattix
Copy link
Contributor

/cc @istio/technical-oversight-committee for review

@whitneygriffith
Copy link
Contributor Author

PTAL @howardjohn @therealmitchconnors

Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com>
@whitneygriffith
Copy link
Contributor Author

/test gencheck

1 similar comment
@ericvn
Copy link
Contributor

ericvn commented May 22, 2024

/test gencheck

@istio-testing istio-testing merged commit 08f80ce into istio:master May 22, 2024
5 checks passed
@whitneygriffith whitneygriffith deleted the new-api-fields branch May 23, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants