Skip to content

Commit

Permalink
Fix eds cluster loadassignment with invalid endpoint (#50690)
Browse files Browse the repository at this point in the history
* fix eds cluster has invalid endpoints

* Add release note

* Fix specical case ep address empty

* add uds addr check

* use IsValidIP
  • Loading branch information
hzxuzhonghu authored and zirain committed Apr 28, 2024
1 parent 7e1e4ae commit b410f74
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 0 deletions.
1 change: 1 addition & 0 deletions pilot/pkg/xds/endpoints/ep_filters_test.go
Expand Up @@ -834,6 +834,7 @@ func testShards() *model.EndpointIndex {
// network1 has one endpoint in each cluster
{Cluster: "cluster1a"}: {
{Network: "network1", Address: "10.0.0.1"},
{Network: "network1", Address: "foo.bar"}, // endpoint generated from ServiceEntry
},
{Cluster: "cluster1b"}: {
{Network: "network1", Address: "10.0.0.2"},
Expand Down
8 changes: 8 additions & 0 deletions releasenotes/notes/50688.yaml
@@ -0,0 +1,8 @@
apiVersion: release-notes/v2
kind: bug-fix
area: traffic-management
issue:
- 50688
releaseNotes:
- |
**Fixed** build EDS typed cluster endpoints with domain address.

0 comments on commit b410f74

Please sign in to comment.