Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add "app.kubernetes.io/name" to gateway.podlabels #50540

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

add "app.kubernetes.io/name" to gateway.podlabels #50540

wants to merge 5 commits into from

Commits on Apr 18, 2024

  1. add "app.kubernetes.io/name" to gateway.podLabels 

    Goal: to have matching "app.kubernetes.io/name" label and value for on `deployment` and `pod` for metrics.

Using `.Values.labels` for that will lead to duplicate "app.kubernetes.io/name" labels.
    @lukmdo
    lukmdo committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    f32ab97 View commit details
    Browse the repository at this point in the history

  2. opt: (cleanup) move istio.io/rev label to gateway.podLabels 

    this is not-functional change only optional cleanup
    @lukmdo
    lukmdo committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    0457dfc View commit details
    Browse the repository at this point in the history

Commits on Apr 19, 2024

  1. review: add app.kubernetes.io/version to gateway.podLabels 

    istio#50540 (review)
    @lukmdo
    lukmdo committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    281c532 View commit details
    Browse the repository at this point in the history

  2. review: (opt cleanup) use gateway.podLabels in gateway.labels 

    istio#50540 (review)

help managing common labels
    @lukmdo
    lukmdo committed Apr 19, 2024
    Configuration menu
    Copy the full SHA
    3ac9a50 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2024

  1. review: add gateway.sidecarInjectionLabels, drop gateway.podLabels

    @lukmdo
    lukmdo committed Apr 28, 2024
    Configuration menu
    Copy the full SHA
    5f32127 View commit details
    Browse the repository at this point in the history