Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt ServiceEntry validate message #50594

Closed

Conversation

j2gg0s
Copy link
Contributor

@j2gg0s j2gg0s commented Apr 22, 2024

Please provide a description of this PR:

"If we enable DNS auto allocation and cache, addresses are not required for the ServiceEntry of the TCP. Although we cannot determine whether the relevant configuration is enabled during the validation, including this information in the warn message is still very helpful to users."

@j2gg0s j2gg0s requested a review from a team as a code owner April 22, 2024 12:52
@istio-policy-bot istio-policy-bot added area/user experience release-notes-none Indicates a PR that does not require release notes. labels Apr 22, 2024
@istio-policy-bot
Copy link

😊 Welcome @j2gg0s! This is either your first contribution to the Istio istio repo, or it's been
a while since you've been here.

You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 22, 2024
@istio-testing
Copy link
Collaborator

Hi @j2gg0s. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MorrisLaw
Copy link
Contributor

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels May 15, 2024
@MorrisLaw
Copy link
Contributor

@j2gg0s thanks for the PR! Looks like there is some conflict resolution needed though

@j2gg0s j2gg0s closed this May 15, 2024
@j2gg0s
Copy link
Contributor Author

j2gg0s commented May 15, 2024

@j2gg0s thanks for the PR! Looks like there is some conflict resolution needed though

Master has added related message in error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/user experience ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants