tests: drop hardcoded kube-system CNI #50667
Merged
+10
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howardjohn
added
the
release-notes-none
istio-testing
added
the
size/XS
dhawton
reviewed
Apr 24, 2024
bleggett
approved these changes
May 1, 2024
This was originally set in 2021 to make the tests run on GKE/others. Long ago, the installation automatically detects the kube-system requirements and installs appropriately. As-is, this means if you install the integ test on a running cluster off GKE, it will end up with 2 CNIs and cause havoc
howardjohn
force-pushed
the
tf/drop-kube-system
branch
from
4e6dc96
to
bdebf62
Compare
istio-testing
added
size/S
dhawton
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was originally set in 2021 to make the tests run on GKE/others.
Long ago, the installation automatically detects the kube-system
requirements and installs appropriately.
As-is, this means if you install the integ test on a running cluster off
GKE, it will end up with 2 CNIs and cause havoc