Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom labels added for istio-cni deployment and pods in helm chart #50694

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
10 changes: 10 additions & 0 deletions manifests/charts/istio-cni/templates/daemonset.yaml
Expand Up @@ -13,10 +13,15 @@ metadata:
namespace: {{ .Release.Namespace }}
labels:
k8s-app: istio-cni-node
app: istio-cni
release: {{ .Release.Name }}
istio.io/rev: {{ .Values.revision | default "default" }}
install.operator.istio.io/owning-resource: {{ .Values.ownerName | default "unknown" }}
operator.istio.io/component: "Cni"
{{- if .Values.cni.labels }}
# Custom Labels
{{ toYaml .Values.cni.labels | indent 4 }}
{{- end }}
spec:
selector:
matchLabels:
Expand All @@ -29,8 +34,13 @@ spec:
metadata:
labels:
k8s-app: istio-cni-node
app: istio-cni
sidecar.istio.io/inject: "false"
istio.io/dataplane-mode: none
{{- if .Values.cni.podLabels }}
# Custom Labels
{{ toYaml .Values.cni.podLabels | indent 8 }}
{{- end }}
annotations:
sidecar.istio.io/inject: "false"
# Add Prometheus Scrape annotations
Expand Down
8 changes: 8 additions & 0 deletions manifests/charts/istio-cni/values.yaml
Expand Up @@ -32,6 +32,14 @@ defaults:
# Allows user to set custom affinity for the DaemonSet
affinity: {}

# Custom labels on Daemonset level, for eg - FinOps/teams labels
labels: {}
# team-owner: finops

# Custom labels on Pod level, for eg - FinOps/teams labels
podLabels: {}
# team-owner: finops

nischay30 marked this conversation as resolved.
Show resolved Hide resolved
# Custom annotations on pod level, if you need them
podAnnotations: {}

Expand Down
8 changes: 8 additions & 0 deletions releasenotes/notes/cni-custom-labels.yaml
@@ -0,0 +1,8 @@
apiVersion: release-notes/v2
kind: feature
area: installation
issue:
- https://github.com/istio/istio/issues/50372
releaseNotes:
- |
**Added** labels and podLabels fields to istio-cni chart