bump istio-proxy #50813
Merged
bump istio-proxy #50813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zirain
requested review from
a team,
costinm,
linsun,
howardjohn,
stevenctl,
ericvn and
hzxuzhonghu
as code owners
istio-policy-bot
added
the
release-notes-none
istio-testing
added
the
size/XS
howardjohn
approved these changes
May 2, 2024
| @@ -2422,7 +2422,7 @@ func buildQuery(src, dst echo.Instance) prometheus.Query { | |||
| destns := dst.NamespaceName() | |||
|
|
|||
| labels := map[string]string{ | |||
| "reporter": "destination", | |||
| "reporter": "waypoint", | |||
There was a problem hiding this comment.
we fixed a bunch of labels, seems like we should have more changes here @keithmattix
There was a problem hiding this comment.
Maybe need to add some more(new) labels
There was a problem hiding this comment.
Yeah there should be more things, but I don't see unknown checks below. Is the test ignoring them?
ericvn
approved these changes
May 2, 2024
it won't, c-ares on 1.30 didn't upgraded. |
lei-tang
approved these changes
May 2, 2024
kyessenov
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description of this PR:
fix: #50698
This PR contains three parts: