allow missing svc port for sandwich #1054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istio-testing
added
the
size/M
MorrisLaw
reviewed
May 13, 2024
bleggett
reviewed
May 13, 2024
howardjohn
approved these changes
May 13, 2024
|
@stevenctl I approved with hold since I saw outstanding comments btw |
istio-testing
added
size/L
|
Added the UT, and made this codepath used in the sandwich_proxy_protocol namespaced test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you create a sandwiched-waypoint with
The
hboneMtlsPorton a gateway address will still be 15008 (we want it to be whatever the zTunnel port is).When we
find_upstreamfor this waypoint's service, the port is irrelevant. Currently I have to create a bogus 15008 listener as a workaround to make this check pass in zTunnel.The way this PR is written could possibly break things in the future though.. it would assume inbound_tunnel does port mapping. It sort of does that via application_tunnel.