fix: build wheel by requirements.txt not pack #431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the convenient and amazing collection for all the grad-cam based method.
You just published the 1.4.7 version in June, 15, 2023. As for the changing in setuptool, people cannot install the from
pip install grad-cam
right now.It will come into a build failure in wheel like this
the setup.py need requirement.txt as usual, but the setuptools changing in recent half years make it not pack requirement.txt anymore.
This PR is a fast and minial fixing, just adding a config file reading by wheel builder to include requirements.txt mannully
If you need I can make a PR to turn the whole package into a modern pakcage tool like poetry with full tests.
Reference: