Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing dependency (fix #1269) #1271

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

gnodet
Copy link

@gnodet gnodet commented Jan 5, 2022

No description provided.

@gnodet
Copy link
Author

gnodet commented Jan 5, 2022

This is clearly not sufficient to allow parallel builds. There are additional problems in test dependencies, as the jacoco-maven-plugin is used in various places during tests but not referenced as a dependency.

I'll let jacoco developpers fix the problem...

@marchof
Copy link
Member

marchof commented Jan 5, 2022

Also some of the (IT) tests allocate ports. Probably this will result in random failure with parallel builds.

Out of curiosity: What are you working on to require parallel JaCoCo builds?

@gnodet
Copy link
Author

gnodet commented Jan 5, 2022

Also some of the (IT) tests allocate ports. Probably this will result in random failure with parallel builds.

Out of curiosity: What are you working on to require parallel JaCoCo builds?

I'm just working on mvnd and had the report the jacoco was failing with it (see apache/maven-mvnd#558), so I investigated a bit.

marchof
marchof previously approved these changes Jan 6, 2022
@Godin Godin dismissed marchof’s stale review May 15, 2023 20:13

As was correctly pointed out - this is clearly not sufficient to allow parallel builds, i.e. doesn't fully fix #1269

@Godin Godin marked this pull request as draft May 15, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants