New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jacoco.append property to the merge goal #1338
base: master
Are you sure you want to change the base?
Conversation
For consistency the Ant goal and CLI should probably get the same option. |
Thanks @muminc for adding the same option to Ant and CLI! Do you have an idea how the new option can actually be tested in our integration test suites? |
…age check using the appended file (which should contain coverage data from all projects)
@marchof Not sure if this what you had in mind. Created integration test where check goal is run afterwards but configured to use appended file as the dataFile. It verifies there is 100% coverage as result of other projects providing coverage to project1. |
@muminc I had two explicit test cases for the append flag in mind (true and false). I implemented it for the dump command: https://gist.github.com/marchof/d18d3d88460467964a83c4e47f85e024 (I can't push to your PR branch, probably because you're working on master) |
@marchof I'd bet on "Allow edits from maintainers" not set - see https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests |
Add jacoco.append property to the merge goal