Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jacoco.append property to the merge goal #1338

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

muminc
Copy link
Contributor

@muminc muminc commented Jun 26, 2022

Add jacoco.append property to the merge goal

@marchof marchof self-assigned this Jun 27, 2022
@marchof
Copy link
Member

marchof commented Jun 27, 2022

For consistency the Ant goal and CLI should probably get the same option.

@marchof
Copy link
Member

marchof commented Jun 27, 2022

Thanks @muminc for adding the same option to Ant and CLI! Do you have an idea how the new option can actually be tested in our integration test suites?

…age check using the appended file (which should contain coverage data from all projects)
@muminc
Copy link
Contributor Author

muminc commented Jun 28, 2022

@marchof Not sure if this what you had in mind. Created integration test where check goal is run afterwards but configured to use appended file as the dataFile. It verifies there is 100% coverage as result of other projects providing coverage to project1.

@marchof
Copy link
Member

marchof commented Jun 30, 2022

@muminc I had two explicit test cases for the append flag in mind (true and false). I implemented it for the dump command:

https://gist.github.com/marchof/d18d3d88460467964a83c4e47f85e024

(I can't push to your PR branch, probably because you're working on master)

@Godin
Copy link
Member

Godin commented Jun 30, 2022

@muminc
Copy link
Contributor Author

muminc commented Jul 9, 2022

@Godin Thanks for the link, I see "Allow edits by maintainers" is ticked.

@marchof Have included your updated DumpTest and made changes to MergeTest. If you are still unable to push changes to PR branch, do think should I raise PR again using different branch?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants