Refactor re-calculation of stackmap frames #1449
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Try to make code more readable by adding a utility class to track types and variable positions on locals * Re-use locals array to avoid object creations
marchof
commented
May 16, 2023
|
|
||
| private final Locals newLocals = new Locals(); | ||
|
|
||
| private static class Locals { |
There was a problem hiding this comment.
Make this class package private and add unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to understand the new code in #893 I was thinking how to refactor the code to make it more comprehensible (at least for me).
@Godin Please feel free to reject this proposal if you don't think it helps.