Align ES index-prefix parameter for jobs

[OpenGuidou]

Which problem is this PR solving?

Proposal to fix #4268
As it's a non-backward compatible change, let me know how you want to handle this.
I'm open to changes.

Short description of the changes

• Align ES index-prefix flag for jobs to what's defined for other jaeger components. This allows to have a single configuration for all items.

[yurishkuro]

I really don't think this PR is useful. It clearly shows that the naming of the flags is all over the place and inconsistent. Fixing one single flag doesn't make the situation any better, it only introduces churn and can break people in 3m who don't notice the deprecation. I don't see any benefits in breaking people for a cosmetic change.

[yurishkuro]

this should log a warning about using deprecated flag

[OpenGuidou]

solved

[OpenGuidou]

We can take the opportunity to review the cli flags in those commands, there are not so many. Let me know and I'll update the others as well.
In my opinion it's still better to fix it at the root and risk breaking people not noticing the warning than pushing the inconsistency downwards to the rest of the ecosystem integration, like with the helm chart.

[yurishkuro]

In my opinion it's still better to fix it at the root and risk breaking people not noticing the warning than pushing the inconsistency downwards to the rest of the ecosystem integration, like with the helm chart.

I disagree. One of the worst sins for a project to do is break users. Your better have strong reasons if you do that, and here I don't see a good reason. It would be nice if we, the maintainers, were more diligent when this inconsistency was introduced the first time, but right now is has already been pushed downwards and adopted, few years ago.

The complexity is also arguable. All these scripts are narrowly scoped to ES maintenance, I don't think it's especially difficult to grasp 10 or so flags, whether they are named consistently or not.