Add support for jcmd Compiler.perfmap #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theothornhill
force-pushed
the
master
branch
2 times, most recently
from
4ab8b08
to
c7ecada
Compare
|
Ping! 😊 |
Xyene
approved these changes
May 28, 2024
|
Thanks - I'll look at the formatting failure. Code was run using the examples from the readme. I'll check if that either needs amending or if I missed something. |
Even though the perf "spec" for jit languages defines the perf map syntax, the jcmd Compiler.perfmap insists on prepending 0x to the addresses. In addition, there's now a way for the jvm to generate the perfmap automatically on exit, making `magic-trace run -multi-thread -snapshot-size 1M -- ./demo/java` return something useful without messing around with perfmap generation. Add these options to the ./demo/java file Signed-off-by: Theodor Thornhill <theo@thornhill.no>
|
I updated the |
|
I've updated the docs, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though the perf "spec" for jit languages define the perf map syntax, the jcmd Compiler.perfmap insists on prepending 0x to the addresses.
In addition, there's now a way for the jvm to generate the perfmap automatically on exit, making
magic-trace run -multi-thread -snapshot-size 1M -- ./demo/javareturn something useful without messing around with perfmap generation. Add these options to the ./demo/java file