Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Remote API Parameters Correction #2802

Merged
merged 44 commits into from May 4, 2024
Merged

Feat: Remote API Parameters Correction #2802

merged 44 commits into from May 4, 2024

Conversation

hahuyhoang411
Copy link
Contributor

@hahuyhoang411 hahuyhoang411 commented Apr 24, 2024 •
edited

Describe Your Changes

  • Add parameters to all remote API for displaying in Jan UI.

Fixes Issues

  • Closes #

Self Checklist

  • OpenAI API
    • Parameters add: gpt-4-turbo, gpt-3.5-turbo, gpt-4-vision-preview
    • Shorten down the list
    • Package version bump
  • Mistral API
    • Parameters add
    • Shorten down the list
    • Package version bump
  • Groq API
    • Parameters add
    • Shorten down the list
    • Package version bump

@hahuyhoang411 hahuyhoang411 self-assigned this Apr 24, 2024
@hahuyhoang411 hahuyhoang411 marked this pull request as ready for review April 24, 2024 08:44
@Van-QA
Copy link
Contributor

Van-QA commented May 2, 2024

Testing OpenAI found this issue, further investigation is needed.
image

@hahuyhoang411
Copy link
Contributor Author

All bugs fixed. Ready to go

@Van-QA
Copy link
Contributor

Van-QA commented May 4, 2024

https://github.com/janhq/jan/actions/runs/8947604036

louis-jan
louis-jan approved these changes May 4, 2024
View reviewed changes
Copy link
Contributor

@louis-jan louis-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Van-QA Van-QA merged commit 092a572 into dev May 4, 2024
17 checks passed
@Van-QA Van-QA deleted the chore/remote-api-params branch May 4, 2024 08:44
@github-actions github-actions bot added this to the v0.5.0 Broken Rice milestone May 4, 2024
@henryh0x1 henryh0x1 mentioned this pull request May 4, 2024
Merged
3 tasks
@Van-QA
Copy link
Contributor

Van-QA commented May 15, 2024

resolve #1810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louis-jan louis-jan louis-jan approved these changes

@Inchoker Inchoker Awaiting requested review from Inchoker

Assignees

@hahuyhoang411 hahuyhoang411

Labels
None yet
Projects
None yet
Milestone
v0.4.13 🌾 Broken Rice
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hahuyhoang411 @Van-QA @louis-jan