Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RHIDP-2069 - [QE] Automate Scenario - Include HTTP Request as pre-loaded Plugin to RHDH #1266

Merged
merged 3 commits into from
May 27, 2024
Merged

RHIDP-2069 - [QE] Automate Scenario - Include HTTP Request as pre-loaded Plugin to RHDH #1266

merged 3 commits into from
May 27, 2024
+167 −134

Conversation

gustavolira
Copy link
Contributor

Description

[QE] Automate Scenario - Include HTTP Request as pre-loaded Plugin to RHDH

Which issue(s) does this PR fix

[- Fixes #?]
https://issues.redhat.com/browse/RHIDP-2069

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@gustavolira gustavolira requested a review from a team as a code owner May 16, 2024 22:51
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1266!

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1266!

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1266!

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1266!

@gustavolira gustavolira force-pushed the RHIDP-2069 branch 2 times, most recently from 0fb4e14 to 847f4cc Compare May 22, 2024 13:35
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1266!

@zdrapela zdrapela mentioned this pull request May 23, 2024
Open
2 tasks
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1266!

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1266!

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1266!

@subhashkhileri
Copy link
Member

/lgtm

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1266!

gustavolira and others added 3 commits May 23, 2024 16:50
@gustavolira
Fixing rbac tests execution
5813a17 
Update openshift-ci-tests.sh to echo RESULT

Changed the behavior in openshift-ci-tests.sh to echo the result instead of exiting the script using the RESULT variable. This modification allows further actions or analysis after the droute_send function call.

Signed-off-by: Gustavo Lira <guga.java@gmail.com>
@gustavolira
RHIDP-2069 [QE] Automate Scenario - Include HTTP Request as pre-loade…
7a79225 
…d Plugin to RHDH
@gustavolira
Improving the execution of the openshift-ci-tests.sh
ea2f235
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 23, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.2% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

The image is available at: quay.io/janus-idp/backstage-showcase:pr-1266!

@subhashkhileri
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm label May 27, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: subhashkhileri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit f03dbfa into janus-idp:main May 27, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@subhashkhileri subhashkhileri subhashkhileri requested changes

@josephca josephca Awaiting requested review from josephca

@rnapoles-rh rnapoles-rh Awaiting requested review from rnapoles-rh

Assignees

@subhashkhileri subhashkhileri

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gustavolira @subhashkhileri @openshift-merge-robot