Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make custom cop inherit RuboCop::Cop::Base #9597

Merged

Conversation

koic
Copy link
Contributor

@koic koic commented May 10, 2024

This is a 🔨 code refactoring.

Summary

This PR uses RuboCop::Cop::Base for custom cops.

Context

Follow rubocop/rubocop#7868.

The legacy RuboCop::Cop::Cop API is soft deprecated and this PR makes custom cop inherit RuboCop::Cop::Base API instead.

maintain any RuboCop extensions, as the legacy API will be removed in RuboCop 2.0.

https://metaredux.com/posts/2020/10/21/rubocop-1-0.html

Follow rubocop/rubocop#7868.

The legacy `RuboCop::Cop::Cop` API is soft deprecated and
this PR makes custom cop inherit `RuboCop::Cop::Base` API instead.

> maintain any RuboCop extensions, as the legacy API
> will be removed in RuboCop 2.0.

https://metaredux.com/posts/2020/10/21/rubocop-1-0.html
Copy link
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 28e10da into jekyll:master May 22, 2024
7 of 11 checks passed
jekyllbot added a commit that referenced this pull request May 22, 2024
github-actions bot pushed a commit that referenced this pull request May 22, 2024
Koichi ITO: Make custom cop inherit `RuboCop::Cop::Base` (#9597)

Merge pull request 9597
@koic koic deleted the make_custom_cop_inherit_rubocop_cop_base branch May 22, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants