Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'Disable project' button from project view #9287

Merged
merged 1 commit into from
May 27, 2024
Merged

Remove 'Disable project' button from project view #9287

merged 1 commit into from
May 27, 2024

Conversation

janfaracik
Copy link
Contributor

@janfaracik janfaracik commented May 18, 2024 •
edited

Reverts the revert in #9272

Fix for the workflow-job-plugin test failure here jenkinsci/workflow-job-plugin#437

Discussed briefly in the last UX Sig, the 'Disable project' (and 'Add/edit description') button take up a lot of vertical space (roughly 100px) and this forces useful information, such as stage view plugin etc down.

My proposal would be just to remove the 'Disable project' button altogether and instead have users rely on the configure screen to disable projects.

Before
image

After
image

Testing done

  • Disable button has been removed, still possible to reenable a project from that view however

Proposed changelog entries

  • Remove 'Disable project' button from project view.

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@jenkinsci/sig-ux

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@timja timja requested a review from NotMyFault May 21, 2024 14:50
@timja timja added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label May 21, 2024
@timja
Copy link
Member

timja commented May 26, 2024

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 26, 2024
@NotMyFault NotMyFault merged commit 69b320f into jenkinsci:master May 27, 2024
16 checks passed
@0023-119
Copy link

I hope the community will make you bring that button back, because this change is truly horrible and the supposed few pixel gains are negligible on current displays.

@HeikoNardmann
Copy link

HeikoNardmann commented May 31, 2024 •
edited

I hope the community will make you bring that button back, because this change is truly horrible and the supposed few pixel gains are negligible on current displays.

I agree. With the same arguments you could state that "Add description" should vanish as well.

I'd prefer to use a different layout with one column with infos to the left and one with buttons to the right.

Or move "Disable Project" to the left to the other links as well.

@MarkEWaite
Copy link
Contributor

I hope the community will make you bring that button back, because this change is truly horrible and the supposed few pixel gains are negligible on current displays.

My experience is in the other direction. I use a Chromebook laptop and vertical space is quite precious when I'm using that laptop. Removing the wasted vertical space gives me a better chance that the actions I frequently perform will not require that I scroll the screen downward. This change is expected to save me multiple clicks and scrolling to see useful information. In those rare cases where I want to disable a job, I click the app bar and disable it.

@timja
Copy link
Member

timja commented May 31, 2024

I click the app bar and disable it.

This moves the disable into the configure job page as its expected to be a rare action and its already available there. Enable has been left on the page as it will be more convenient to quickly enable something and it shouldn't often show.

@0023-119
Copy link

Well it's half of 2024, this button has been there for the last 15 years, back in time when 1280x800 laptops were a norm and yet it is now - in the era of 4K screens everywhere - that you found this particular button space-wasting?
Do you guys even have anyone familiar with human-machine interaction stuff in the team?

Make it in line with "add description" - which of the two is definitely more useless and more easily movable to settings - or make it an option for the user to decide.

Removing it completely is the laziest and worst decision possible.

@gwolf2u
Copy link

gwolf2u commented May 31, 2024

I would rather have it there since it doesn't take that much space anyway
Was easier (in my case) to enable/disable projects on the fly just by clicking the project name not to go to configuration and click save
Was on button click, now is two
Anyway, a redesign of that page would be more useful I'd say

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotMyFault NotMyFault NotMyFault approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Milestone
No milestone
7 participants
@janfaracik @timja @0023-119 @HeikoNardmann @MarkEWaite @gwolf2u @NotMyFault