-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
typst,table - support '.typst-no-figure' and 'typst-figure-kind=kind' #9778
base: main
Are you sure you want to change the base?
Conversation
6e740a2
to
6cd4100
Compare
src/Text/Pandoc/Writers/Typst.hs
Outdated
return $ case Data.List.find (== "typst-no-figure") tabclasses of | ||
return $ case Data.List.find (== "typst:no-figure") tabclasses of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's more straightforward to use a boolean test here: if "typst:no-figure"
elem tabclasses
Something should be added to |
Ok, I've added some. On doing so, I'm now wondering if this PR should additionally support a In addition to that, I now think the handlers for the
The same considerations that applied for |
This is intended to close #9777 in a configurable way.
It also supports a slight generalization of the solution in #9574 by enabling control of the
kind
parameter for#figure()
.I didn't know how to add classes and attributes to a plain markdown table in a clean way and so I used a Lua filter for that, but of course that can be changed if there's a better way to do it.
EDIT: I see that the test failure comes from CI on windows building Pandoc without Lua support. I'm going to change the tests to provide native input.