New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove too early metadata language definition without try-except block #292

Open

HoLuLuLu wants to merge 1 commit into jkwill87:main from HoLuLuLu:fix/mnamer-language-exception

HoLuLuLu commented Jan 31, 2024

Fixes: #289

Changes explaination:

definition of self.metadata.language throws MnamerException if path_data.get("language") is not a valid language (in my case it was the German word "und", which means "and" and is not a language reference at all)
later if condition isn't necessary because self.metadata.language will never be set before
try-except block used makes sure that path_data.get("language") can be converted to a Language, otherwise the metadata language will not be set


          Remove too early metadata language definition without try-except block

155cc97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment