Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix weird transition #660

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DiegoArenaO
Copy link

Based on the fix of the PR #650 by @2h4u to fix the weird transition opening the app.
Adding the inactive case will fix the weird transition when the device is rotated

Diego Arena and others added 2 commits October 29, 2020 13:26
Based on the fix of the PR jonkykong#650 by @2h4u to fix the weird transition opening the app.
Adding the inactive case will fix the weird transition when the device is rotated
@2h4u
Copy link

2h4u commented Oct 30, 2020

I reverted the changes made by #642 since it looks like they only fixed the symptoms but not the root cause of the problem. The SideMenuAnimationController can not operate as indented without a presentationController.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants