Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check related elements outside form (#2156) #2231

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

check related elements outside form (#2156) #2231

wants to merge 3 commits into from

Conversation

SimonHeimberg
Copy link

No description provided.

@SimonHeimberg
Copy link
Author

SimonHeimberg commented Oct 30, 2018 •
edited

Test for new functionality is missing. I need help to write one.

@staabm staabm requested a review from Arkni October 30, 2018 08:15
@SimonHeimberg SimonHeimberg mentioned this pull request Oct 30, 2018
Open
@SimonHeimberg
Copy link
Author

SimonHeimberg commented Oct 30, 2018 •
edited

No new failures when running tests in Firefox.
Could not run tests in edge browser, can not yet load the page.
IE does not even run all tests.

@SimonHeimberg
Copy link
Author

SimonHeimberg commented Oct 30, 2018 •
edited

was unsure if 0b3fbb4 only finds expected error elements, or even normal labels

update:
The correct error elements are found. The messages shown were unclear, probably because I had some title attributes set on the element.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arkni Arkni Awaiting requested review from Arkni

Assignees
No one assigned
Labels
NEEDS REVIEW
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SimonHeimberg @Arkni