Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Drop support for IE (all versions) #5077

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mgol
Copy link
Member

@mgol mgol commented Jul 26, 2022

Summary

This PR is to show what dropping IE support would look like in code. If we make a decision to drop IE in v4, this PR can be merged, guarded on possible review remarks. EDIT: we've decided to land this in 5.0.0.

Of course, dropping IE would open a lot of other doors for various refactors but those would be considered separately.

Size difference:

main @063831b6378d518f9870ec5c4f1e7d5d16e04f36
   raw     gz Filename
 -1969   -608 dist/jquery.min.js
 -1763   -553 dist/jquery.slim.min.js
 -1969   -609 dist-module/jquery.module.min.js
 -1763   -556 dist-module/jquery.slim.module.min.js

Checklist

src/event.js Outdated Show resolved Hide resolved
Comment on lines -366 to -357
// Support: IE 11+
// ...but not arrow key "clicks" of radio inputs, which can have `button` -1 (gh-2343)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firefox doesn't have the behavior from the above comment (click events are not fired for non-primary mouse buttons) so perhaps this all could be removed. But one of our tests checks this condition explicitly so I'd rather leave it for a separate PR.

src/selector.js Outdated Show resolved Hide resolved
} else {
$(id+" input,"+id+" button,"+id+" select,"+id+" textarea").live(type, $cell, blinker);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file has been broken for a long time due to the use of live… But it looks potentially useful so I fixed it.

@mgol mgol added Needs review Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. Core labels Jul 27, 2022
@mgol mgol self-assigned this Jul 29, 2022
@dmethvin
Copy link
Member

dmethvin commented Aug 2, 2022

Seems like the right move at this point. Things clean up nicely!

@mgol mgol added this to the 5.0.0 milestone Aug 8, 2022
@mgol mgol removed the Discuss in Meeting Reserved for Issues and PRs that anyone would like to discuss in the weekly meeting. label Aug 8, 2022
@mgol mgol removed the Needs review label Jan 20, 2023
@mgol mgol force-pushed the drop-ie-support branch 2 times, most recently from 8e858d1 to 54f3294 Compare April 6, 2023 10:30
@ollie-iterators
Copy link

The blog about jquery 3.7.0: https://blog.jquery.com/2023/05/11/jquery-3-7-0-released-staying-in-order/ says that "support for IE will be dropped in jQuery 4.0"

@mgol
Copy link
Member Author

mgol commented May 12, 2023

@ollie-iterators Thanks for the info; that should say 5.0; we’ll fix it.

@vrubleg
Copy link

vrubleg commented Aug 27, 2023

It's 2023, IE11 is 10 years old, half of the web already doesn't work in this browser. IE11 was introduced with Windows 8.1 that is already not supported by a lot of software (including Firefox and Chrome) and libraries (like Qt6+ or Python 3.9+). It makes sense to drop IE earlier.

@mgol
Copy link
Member Author

mgol commented Sep 6, 2023

@vrubleg I understand the sentiment and I admit more than a year has passes since I raised this PR but I really don't want to make any changes to our 4.0.0 plans at this point as any further change is just going to delay the whole thing, and it's already been delayed a lot.

I want to get the beta out with only our current blockers resolved. Once we have that, once we also have the respective Migrate release and the upgrade guide prepared, we can talk about it once again.

@mgol mgol force-pushed the drop-ie-support branch 3 times, most recently from 173239b to b3e684a Compare September 20, 2023 20:25
@nagyimre1980
Copy link

IE drop 4.1.0 ?

@mgol
Copy link
Member Author

mgol commented Sep 21, 2023

@nagyimre1980 No; we treat reducing browser support policy as a breaking change so it has to land in a major version update.

@mgol mgol force-pushed the drop-ie-support branch 2 times, most recently from 36ed210 to a35b89d Compare September 21, 2023 23:45
@mgol mgol force-pushed the drop-ie-support branch 3 times, most recently from 21d7938 to 088ce96 Compare November 20, 2023 13:40
@mgol mgol force-pushed the drop-ie-support branch 2 times, most recently from b74888f to a76a48b Compare March 20, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

None yet

5 participants