Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] jsx-newline: jsx-newline breaking with comments #3747

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented May 3, 2024

Closes #3573

@akulsr0
Copy link
Contributor Author

akulsr0 commented May 7, 2024

Can we rerun the failing test once?

@ljharb
Copy link
Member

ljharb commented May 7, 2024

yep, looks like a fluke; reran.

@akulsr0
Copy link
Contributor Author

akulsr0 commented May 16, 2024

Bumping this up!

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (417e1ca) to head (9d6aa68).
Report is 1 commits behind head on master.

Current head 9d6aa68 differs from pull request most recent head 7722f49

Please upload reports for the commit 7722f49 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3747      +/-   ##
==========================================
- Coverage   97.79%   97.76%   -0.04%     
==========================================
  Files         134      134              
  Lines        9613     9614       +1     
  Branches     3486     3486              
==========================================
- Hits         9401     9399       -2     
- Misses        212      215       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ljharb ljharb force-pushed the akul/fix-jsx-newline-breaking-comments branch from 9d6aa68 to 7722f49 Compare May 31, 2024 23:33
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test passes without your change, and your change is effectively identical, so I'm not sure how it could have fixed anything.

@ljharb ljharb marked this pull request as draft May 31, 2024 23:33
@akulsr0
Copy link
Contributor Author

akulsr0 commented Jun 1, 2024

I remember the same issue mentioned in #3573 was happening for me too, which got fixed by this. But now I am unable to reproduce it :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: jsx-newline sometimes breaks with comments
2 participants