-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] jsx-newline: jsx-newline breaking with comments #3747
base: master
Are you sure you want to change the base?
[Fix] jsx-newline: jsx-newline breaking with comments #3747
Conversation
Can we rerun the failing test once? |
yep, looks like a fluke; reran. |
Bumping this up! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3747 +/- ##
==========================================
- Coverage 97.79% 97.76% -0.04%
==========================================
Files 134 134
Lines 9613 9614 +1
Branches 3486 3486
==========================================
- Hits 9401 9399 -2
- Misses 212 215 +3 ☔ View full report in Codecov by Sentry. |
9d6aa68
to
7722f49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test passes without your change, and your change is effectively identical, so I'm not sure how it could have fixed anything.
I remember the same issue mentioned in #3573 was happening for me too, which got fixed by this. But now I am unable to reproduce it :( |
Closes #3573