Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] no-danger: add customComponentNames option #3748

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented May 6, 2024

Closes #3434

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (417e1ca) to head (fdd934d).
Report is 1 commits behind head on master.

Current head fdd934d differs from pull request most recent head 3db6106

Please upload reports for the commit 3db6106 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3748      +/-   ##
==========================================
- Coverage   97.79%   97.76%   -0.04%     
==========================================
  Files         134      134              
  Lines        9613     9618       +5     
  Branches     3486     3488       +2     
==========================================
+ Hits         9401     9403       +2     
- Misses        212      215       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/rules/no-danger.md Outdated Show resolved Hide resolved
lib/rules/no-danger.js Outdated Show resolved Hide resolved
lib/rules/no-danger.js Outdated Show resolved Hide resolved
lib/rules/no-danger.js Outdated Show resolved Hide resolved
tests/lib/rules/no-danger.js Show resolved Hide resolved
@akulsr0
Copy link
Contributor Author

akulsr0 commented May 16, 2024

Let me know if anything is pending here else can we proceed towards merging it?

@ljharb
Copy link
Member

ljharb commented May 24, 2024

it's good to land; i want to cut a patch release before landing new semver-minor things, is all :-)

@ljharb ljharb force-pushed the akul/no-danger-allow-custom-components branch from a46e263 to 3db6106 Compare May 31, 2024 23:38
@ljharb ljharb changed the title [Feat] no-danger: allow custom components as option for no-danger [New] no-danger: add customComponentNames option May 31, 2024
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but i'm going to hold off landing new semver-minors for a bit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

feat: no-danger find props on all components (not just native)
2 participants