-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] no-danger
: add customComponentNames
option
#3748
base: master
Are you sure you want to change the base?
[New] no-danger
: add customComponentNames
option
#3748
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3748 +/- ##
==========================================
- Coverage 97.79% 97.76% -0.04%
==========================================
Files 134 134
Lines 9613 9618 +5
Branches 3486 3488 +2
==========================================
+ Hits 9401 9403 +2
- Misses 212 215 +3 ☔ View full report in Codecov by Sentry. |
Let me know if anything is pending here else can we proceed towards merging it? |
it's good to land; i want to cut a patch release before landing new semver-minor things, is all :-) |
a46e263
to
3db6106
Compare
no-danger
: add customComponentNames
option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but i'm going to hold off landing new semver-minors for a bit.
Closes #3434