Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] no-render-return-undefined: disallow components rendering undefined #3750

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

akulsr0
Copy link
Contributor

@akulsr0 akulsr0 commented May 8, 2024

Closes #3020

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.32%. Comparing base (4467db5) to head (34b6a94).
Report is 3 commits behind head on master.

❗ Current head 34b6a94 differs from pull request most recent head 8aec646. Consider uploading reports for the commit 8aec646 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #3750       +/-   ##
===========================================
- Coverage   97.71%   44.32%   -53.40%     
===========================================
  Files         133        6      -127     
  Lines        9470      282     -9188     
  Branches     3469      102     -3367     
===========================================
- Hits         9254      125     -9129     
+ Misses        216      157       -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akulsr0 akulsr0 marked this pull request as ready for review May 15, 2024 10:35
@ljharb ljharb marked this pull request as draft May 15, 2024 17:23
@akulsr0
Copy link
Contributor Author

akulsr0 commented May 16, 2024

@ljharb Let me know your thoughts on this!

@akulsr0 akulsr0 marked this pull request as ready for review May 18, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

React 18: Warn when components render undefined
1 participant