Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement native tmux integration #3787

Merged
merged 4 commits into from May 18, 2024
Merged

Implement native tmux integration #3787

merged 4 commits into from May 18, 2024

Conversation

junegunn
Copy link
Owner

@junegunn junegunn commented May 9, 2024

Add native --tmux option to replace fzf-tmux script.

Usage

# --tmux [center|top|bottom|left|right][,SIZE[%]][,SIZE[%]]

# Center, 50% width 50% height
fzf --tmux center

# Center, 80% width and height
fzf --tmux 80%

# Center ,100% width and 50% height
fzf --tmux 100%,50%

# Left, 40% width
fzf --tmux left,40%

# Left, 40% width, 90% height
fzf --tmux left,40%,90%

# Top, 40% height
fzf --tmux top,40%

# Top, 90% height, 40% height
fzf --tmux top,90%,40%

Pros

  • Simpler and more robust implementation
  • Simpler distribution
  • Easier to use
  • Handles become inside tmux popup better
  • Properly propagates environment variables

Cons

  • Requires tmux 3.3 or later
  • Only opens in a popup which cannot be zoomed

@junegunn junegunn self-assigned this May 9, 2024
@junegunn junegunn force-pushed the tmux branch 7 times, most recently from 25ffeb2 to fe95484 Compare May 9, 2024 17:35
@junegunn junegunn marked this pull request as draft May 9, 2024 17:36
junegunn added a commit to junegunn/fzf-git.sh that referenced this pull request May 10, 2024
@junegunn junegunn marked this pull request as ready for review May 10, 2024 08:56
@junegunn junegunn force-pushed the tmux branch 3 times, most recently from ecd5ad6 to f769c40 Compare May 14, 2024 15:31
@junegunn junegunn changed the base branch from master to devel May 18, 2024 08:08
@junegunn junegunn merged commit 04dfb14 into devel May 18, 2024
5 checks passed
@junegunn junegunn deleted the tmux branch May 18, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant