Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: filter & list api for payment & refunds #620

Merged
merged 27 commits into from May 23, 2024
Merged

chore: filter & list api for payment & refunds #620

merged 27 commits into from May 23, 2024

Conversation

gitanjli525
Copy link
Contributor

@gitanjli525 gitanjli525 commented May 3, 2024 •
edited

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • updated Filter api: now it fetches all the filters at once from backend
  • updated List api: all or any of the filters can be applied now without any dependency on weather date is selected or not in filters
  • connector label filters appear when any of the connector filter is selected
  • payment method types filters appear when any of the payment method is selected

image

image

https://github.com/juspay/hyperswitch-cloud/issues/4851

Motivation and Context

How did you test it?

Checklist

  • I ran npm run re:build
  • I reviewed submitted code
  • I added unit tests for my changes where possible

@gitanjli525 gitanjli525 added the S-waiting-on-author Status: This PR is incomplete or needs to address review comments label May 3, 2024
@gitanjli525 gitanjli525 self-assigned this May 3, 2024
@gitanjli525 gitanjli525 requested a review from a team as a code owner May 3, 2024 11:56
@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels May 15, 2024
@gitanjli525 gitanjli525 requested review from sagarnaikjuspay and removed request for Riddhiagrawal001 and PritishBudhiraja May 15, 2024 14:05
sagarnaikjuspay
sagarnaikjuspay reviewed May 16, 2024
View reviewed changes
src/components/Filter.res Outdated Show resolved Hide resolved
src/components/RemoteFilter.res Outdated Show resolved Hide resolved
src/components/RemoteFilter.res Outdated Show resolved Hide resolved
src/screens/Order/OrderUIUtils.res Show resolved Hide resolved
src/screens/Order/OrderUIUtils.res Outdated Show resolved Hide resolved
src/screens/Refunds/Refund.res Outdated Show resolved Hide resolved
src/screens/Refunds/RefundUtils.res Outdated Show resolved Hide resolved
src/screens/Refunds/RefundUtils.res Outdated Show resolved Hide resolved
src/screens/Refunds/RefundUtils.res Outdated Show resolved Hide resolved
src/screens/Refunds/RefundUtils.res Outdated Show resolved Hide resolved
@gitanjli525 gitanjli525 added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label May 22, 2024
@JeevaRamu0104 JeevaRamu0104 added S-waiting-on-author Status: This PR is incomplete or needs to address review comments and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 22, 2024
@gitanjli525 gitanjli525 added S-waiting-on-review Status: This PR has been implemented and needs to be reviewed and removed S-waiting-on-author Status: This PR is incomplete or needs to address review comments labels May 22, 2024
@JeevaRamu0104 JeevaRamu0104 added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 5900070 May 23, 2024
5 of 6 checks passed
@JeevaRamu0104 JeevaRamu0104 deleted the list-filter branch May 23, 2024 06:57
@github-actions github-actions bot added Closed Applied to issues or pull requests that have been successfully resolved or completed and removed S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeevaRamu0104 JeevaRamu0104 JeevaRamu0104 approved these changes

@Riddhiagrawal001 Riddhiagrawal001 Awaiting requested review from Riddhiagrawal001

@sagarnaikjuspay sagarnaikjuspay Awaiting requested review from sagarnaikjuspay

Assignees

@gitanjli525 gitanjli525

Labels
Closed Applied to issues or pull requests that have been successfully resolved or completed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Enhance]: list & filter api enhancements
4 participants
@gitanjli525 @Riddhiagrawal001 @JeevaRamu0104 @sagarnaikjuspay