fix: compressed layout dynamic fields card #353
+98
−56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PritishBudhiraja
added
the
Ready for Review
prafulkoppalkar
previously approved these changes
May 7, 2024
src/Components/DynamicFields.res
Outdated
|
|
||
| <RenderIf condition={fieldsArr->Array.length > 0}> | ||
| {<> | ||
| <RenderIf | ||
| condition={dynamicFieldsToRenderOutsideBilling->Array.length > 0 && !isSpacedInnerLayout}> |
There was a problem hiding this comment.
This condition can also be true when for payment methods other than cards
ArushKapoorJuspay
approved these changes
May 7, 2024
PritishBudhiraja
added
Development Blocked
prafulkoppalkar
added
DO NOT MERGE
vsrivatsa-juspay
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Compressed layout for cards dynamic fields
How did you test it?
Passing innerLayout prop
Checklist
npm run re:build