refactor(cards,router): Remove duplicated card number interface

juspay · Apr 22, 2024 · 7d2b90a · 7d2b90a
1 parent 110bf22
commit 7d2b90a
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 6 deletions.
diff --git a/crates/api_models/src/payment_methods.rs b/crates/api_models/src/payment_methods.rs
@@ -379,7 +379,7 @@ impl From<CardDetailFromLocker> for payments::AdditionalCardInfo {
             card_isin: item.card_isin,
             card_extended_bin: item
                 .card_number
-                .map(|card_number| card_number.get_card_extended_bin()),
+                .map(|card_number| card_number.get_extended_card_bin()),
             card_exp_month: item.expiry_month,
             card_exp_year: item.expiry_year,
             card_holder_name: item.card_holder_name,

diff --git a/crates/cards/src/validate.rs b/crates/cards/src/validate.rs
@@ -24,7 +24,6 @@ impl CardNumber {
     pub fn get_card_isin(self) -> String {
         self.0.peek().chars().take(6).collect::<String>()
     }
-
     pub fn get_extended_card_bin(self) -> String {
         self.0.peek().chars().take(8).collect::<String>()
     }
@@ -42,9 +41,6 @@ impl CardNumber {
             .rev()
             .collect::<String>()
     }
-    pub fn get_card_extended_bin(self) -> String {
-        self.0.peek().chars().take(8).collect::<String>()
-    }
 }
 
 impl FromStr for CardNumber {

diff --git a/crates/router/src/core/payments/helpers.rs b/crates/router/src/core/payments/helpers.rs
@@ -3623,7 +3623,7 @@ pub async fn get_additional_payment_data(
     match pm_data {
         api_models::payments::PaymentMethodData::Card(card_data) => {
             let card_isin = Some(card_data.card_number.clone().get_card_isin());
-            let card_extended_bin = Some(card_data.card_number.clone().get_card_extended_bin());
+            let card_extended_bin = Some(card_data.card_number.clone().get_extended_card_bin());
             let last4 = Some(card_data.card_number.clone().get_last4());
             if card_data.card_issuer.is_some()
                 && card_data.card_network.is_some()