feat(analytics): Added load time metric for sdk, added percentile aggregate enum #4301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
vsrivatsa-juspay
force-pushed
the
feat/sdk_analytics_load_time_metrics
branch
from
ba318e8
to
633b54c
Compare
vsrivatsa-juspay
force-pushed
the
feat/sdk_analytics_load_time_metrics
branch
from
83b0f8c
to
97158e2
Compare
ivor-juspay
reviewed
May 8, 2024
| @@ -7,7 +7,8 @@ use super::metrics::SdkEventMetricRow; | |||
| pub struct SdkEventMetricsAccumulator { | |||
| pub payment_attempts: CountAccumulator, | |||
| pub payment_methods_call_count: CountAccumulator, | |||
| pub average_payment_time: AverageAccumulator, | |||
| pub average_payment_time: CountAccumulator, | |||
| pub load_time: CountAccumulator, | |||
There was a problem hiding this comment.
is this correct with percentile? can you share a query?
There was a problem hiding this comment.
also why is average_payment_time changed to CountAccumulator?
There was a problem hiding this comment.
@ivor-juspay wanted to rename the metric to payment_time since its now the median value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Added load time metric for sdk, added percentile aggregate enum
Additional Changes
Motivation and Context
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy