Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(clickhouse): Init Clickhouse container on startup #4365

Merged
merged 6 commits into from May 6, 2024
Merged

feat(clickhouse): Init Clickhouse container on startup #4365

merged 6 commits into from May 6, 2024

Conversation

lsampras
Copy link
Member

@lsampras lsampras commented Apr 15, 2024 •
edited

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Add initialization scripts for clickhouse
  • these scripts will auto run on container creation saving user hassle for creating tables
  • Adding dashboard & SDK services to docker compose

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

docker compose up -d clickhouse-server

then open http://localhost:8123/play & execute query show tables

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@lsampras lsampras requested review from a team as code owners April 15, 2024 19:06
@lsampras lsampras self-assigned this Apr 15, 2024
@lsampras lsampras changed the title feat(clickhouse): init Clickhouse container on startup feat(clickhouse): Init Clickhouse container on startup Apr 15, 2024
ivor-juspay
ivor-juspay previously approved these changes Apr 16, 2024
View reviewed changes
@lsampras @vsrivatsa-juspay
feat(docker-compose): add logging env
44224d1 
Co-authored-by: Vrishab Srivatsa <136090360+vsrivatsa-juspay@users.noreply.github.com>
ivor-juspay
ivor-juspay previously approved these changes Apr 16, 2024
View reviewed changes
@lsampras lsampras requested a review from a team as a code owner April 16, 2024 11:15
ivor-juspay
ivor-juspay previously approved these changes Apr 18, 2024
View reviewed changes
ThisIsMani
ThisIsMani previously approved these changes Apr 23, 2024
View reviewed changes
SanchithHegde
SanchithHegde previously approved these changes Apr 23, 2024
View reviewed changes
@likhinbopanna likhinbopanna added this pull request to the merge queue May 6, 2024
Merged via the queue into main with commit 89e5884 May 6, 2024
9 of 12 checks passed
@likhinbopanna likhinbopanna deleted the ckh_init_scripts branch May 6, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsrivatsa-juspay vsrivatsa-juspay vsrivatsa-juspay left review comments

@SanchithHegde SanchithHegde SanchithHegde approved these changes

@ShivanshMathurJuspay ShivanshMathurJuspay ShivanshMathurJuspay approved these changes

@ThisIsMani ThisIsMani ThisIsMani left review comments

@ivor-juspay ivor-juspay ivor-juspay left review comments

Assignees

@lsampras lsampras

Labels
A-Analytics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@lsampras @SanchithHegde @ThisIsMani @ShivanshMathurJuspay @vsrivatsa-juspay @ivor-juspay @likhinbopanna