chore(deps): change precision point of time #4401
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracarys18
added
A-core
SanchithHegde
previously approved these changes
Apr 19, 2024
dracarys18
changed the title
akshay-97
previously approved these changes
Apr 19, 2024
dracarys18
dismissed stale reviews from akshay-97 and SanchithHegde
via
dfd6b30
dracarys18
changed the title
dracarys18
changed the title
15 tasks
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Changed timeprecision from 3 to 6
Motivation and Context
This fixes the bug in time crate where the seconds get rounded off to 60. More on this issue here
How did you test it?
Cannot be tested on sandbox.
You can clone this repo and do,
Checklist
cargo +nightly fmt --allcargo clippy