ci(cypress): Trustpay collection fix #4410
Conversation
…en-capture-status-handle * 'main' of github.com:juspay/hyperswitch: ci(cypress): Add save card flow (#4327)
…en-capture-status-handle * 'main' of github.com:juspay/hyperswitch: feat(router): add retrieve poll status api (#4358)
…press-for-more-control * 'main' of github.com:juspay/hyperswitch: feat(payments): add amount and connector id filter in list (#4354) feat(connector): [NMI] External 3DS flow for Cards (#4385) test(cypress): Update ConnectorAuth Details (#4386) chore(version): 2024.04.18.0 fix(router): make payment_instrument optional (#4389) fix(config): remove `merchant_business_country` from the connector configs as enums can not be handled in this toml file (#4383) feat(payment_link): Add support for saved payment method option for payment link (#4373)
likhinbopanna
changed the base branch from
main
to
refactor-cypress-for-more-control
likhinbopanna
force-pushed
the
trustpay_collection_fix
branch
from
d7c9e96
to
1a792e0
Compare
likhinbopanna
added
A-CI-CD
| @@ -25,7 +25,7 @@ | |||
| // Cypress.Commands.overwrite('visit', (originalFn, url, options) => { ... }) | |||
|
|
|||
| // commands.js or your custom support file | |||
| import ConnectorAuthDetails from "../../../.github/secrets/creds.json"; | |||
There was a problem hiding this comment.
@pixincreate We can add the path as env then everyone would just export the path instead of updating it here!
We can take up that change in this pr may be?
There was a problem hiding this comment.
@likhinbopanna is the change mentioned above is done?
There was a problem hiding this comment.
i have just reverted the connectorAuthDetails and that is done
There was a problem hiding this comment.
I'll take this up and update it on my PR or raise another PR targeting this branch so that no conflicts would occur...
There was a problem hiding this comment.
Also @likhinbopanna Could you add the test screenshot of assertions added for trustpay?
| @@ -25,7 +25,7 @@ | |||
| // Cypress.Commands.overwrite('visit', (originalFn, url, options) => { ... }) | |||
|
|
|||
| // commands.js or your custom support file | |||
| import ConnectorAuthDetails from "../../../.github/secrets/creds.json"; | |||
There was a problem hiding this comment.
@pixincreate We can add the path as env then everyone would just export the path instead of updating it here!
We can take up that change in this pr may be?
| if (response.body.hasOwnProperty("status")) { | ||
| expect(response.body).to.have.property("status"); | ||
| } |
There was a problem hiding this comment.
can we have a check for status code, if it is 2xx, they we always expect status, if 4xx, we ll always expect error code and message
| else if(response.body.error.type === "invalid_request") { | ||
| if(response.body.error.message === "Payment method type not supported") { | ||
| expect(response.body.error).to.deep.equal(Errors.paymentMethodErrors[globalState.get("connectorId")].paymentMethodUnsupportedError); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Can we move this to manual else if block, since we are explicitly saying Manual Capture for trustpay is not supported
pixincreate
force-pushed
the
refactor-cypress-for-more-control
branch
4 times, most recently
from
0db9ca3
to
fb73ec0
Compare
Type of Change
Description
Fixed manual capture flow for Trustpay collection in cypress tool as manual capture is not supported for Trustpay and I've fixed the assertion since Trustpay and Bluesnap don't support mandates
Additional Changes
Motivation and Context
Trustpay and bluesnap collections were failing in cypress automation
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy