New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(masking): mask email while logging SQL query #4436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracarys18
added
A-core
Area: Core flows
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
labels
Apr 23, 2024
dracarys18
changed the title
fix(masking): mask email during query
fix(masking): mask email while logging SQL query
Apr 23, 2024
lsampras
previously approved these changes
Apr 23, 2024
ThisIsMani
previously approved these changes
Apr 23, 2024
racnan
reviewed
Apr 23, 2024
racnan
approved these changes
Apr 23, 2024
ThisIsMani
approved these changes
Apr 23, 2024
15 tasks
SanchithHegde
removed
the
S-waiting-on-review
Status: This PR has been implemented and needs to be reviewed
label
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Pass the masked email in the SQL query function.
Motivation and Context
This fixes plaintext logging of email during find and update users by email. In this change instead of passing the plain-text email into the function, changed it to masked email which will mask the email while logging.
How did you test it?
Checklist
cargo +nightly fmt --all
cargo clippy