Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(connector): [MiFinity] add connector template code #4447

Merged
merged 12 commits into from May 7, 2024

Conversation

swangi-kumari
Copy link
Contributor

@swangi-kumari swangi-kumari commented Apr 24, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

This PR has template code for connector for MiFinity connector

How did you test it?

  • No test case Required

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@swangi-kumari swangi-kumari added A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement labels Apr 24, 2024
@swangi-kumari swangi-kumari self-assigned this Apr 24, 2024
@swangi-kumari swangi-kumari requested review from a team as code owners April 24, 2024 06:14
@@ -194,6 +194,7 @@ gocardless.base_url = "https://api-sandbox.gocardless.com"
helcim.base_url = "https://api.helcim.com/"
iatapay.base_url = "https://sandbox.iata-pay.iata.org/api/v1"
klarna.base_url = "https://api-na.playground.klarna.com/"
mifinity.base_url = "https://demo.mifinity.com"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
mifinity.base_url = "https://demo.mifinity.com"
mifinity.base_url = "https://demo.mifinity.com/"

Put a / in the end at all the places you defined base url

crates/router/src/core/admin.rs Show resolved Hide resolved
SamraatBansal
SamraatBansal previously approved these changes May 7, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue May 7, 2024
Merged via the queue into main with commit d974e6e May 7, 2024
9 of 12 checks passed
@likhinbopanna likhinbopanna deleted the mifinity-template-code branch May 7, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-integration Area: Connector integration C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants