fix: reject experiment contexts with variantIds
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datron
reviewed
May 6, 2024
Datron
reviewed
May 6, 2024
Datron
previously requested changes
May 6, 2024
mahatoankitkumar
requested changes
May 7, 2024
ShubhranshuSanjeev
force-pushed
the
fix/variantIds-in-experiment-context
branch
from
fd1550e
to
deee03f
Compare
ShubhranshuSanjeev
force-pushed
the
fix/variantIds-in-experiment-context
branch
from
deee03f
to
98ff2ff
Compare
pratikmishra356
approved these changes
May 10, 2024
ShubhranshuSanjeev
force-pushed
the
fix/variantIds-in-experiment-context
branch
2 times, most recently
from
ee3a6a3
to
74fe771
Compare
mahatoankitkumar
requested changes
May 14, 2024
ShubhranshuSanjeev
force-pushed
the
fix/variantIds-in-experiment-context
branch
from
74fe771
to
91b1940
Compare
ShubhranshuSanjeev
force-pushed
the
fix/variantIds-in-experiment-context
branch
from
91b1940
to
e73f08c
Compare
- validating experiment contexts to not have `variantIds` as dimensions - excluded `variantIds` in experiment and context form
ShubhranshuSanjeev
force-pushed
the
fix/variantIds-in-experiment-context
branch
from
e73f08c
to
df9be71
Compare
mahatoankitkumar
approved these changes
May 17, 2024
pratikmishra356
approved these changes
May 17, 2024
ShubhranshuSanjeev
force-pushed
the
fix/variantIds-in-experiment-context
branch
from
df9be71
to
321cca9
Compare
Datron
approved these changes
May 17, 2024
| @@ -109,7 +109,7 @@ fn get_functions_map( | |||
| } | |||
|
|
|||
| pub fn validate_value_with_function( | |||
| fun_name: &str, | |||
| _fun_name: &str, | |||
There was a problem hiding this comment.
If the name is not used, we could just remove it? This is beyond the scope of the PR, but a suggestion. If the warning isn't present, will we remember to remove this?
| @@ -9,6 +9,7 @@ use service_utils::service::types::ExperimentationFlags; | |||
| enum Dimensions { | |||
| OS(String), | |||
| CLIENT(String), | |||
| VARIANTIDS(String), | |||
| } | |||
|
|
|||
| fn single_dimension_ctx_gen(value: Dimensions) -> serde_json::Value { | |||
There was a problem hiding this comment.
We should remove this from OS superposition. Out of the scope of this PR
| @@ -105,6 +105,7 @@ pub fn get_tenants() -> Vec<String> { | |||
| .unwrap_or(vec![]) | |||
| } | |||
|
|
|||
| #[allow(dead_code)] | |||
There was a problem hiding this comment.
Is the a fix for the clippy warning? Can we let the warning persist and find the root cause?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
variantIdsdimension, which is specific for experimentation-platform use, can be passed in the context when creating experiments.Solution
variantIdsas dimensionsvariantIdsfrom the dropdown in create experiment and create context form