fix: creating experiments for default-config (no context) #38
+133
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahatoankitkumar
requested changes
May 8, 2024
crates/experimentation_platform/src/api/experiments/handlers.rs
Outdated
Show resolved
Hide resolved
mahatoankitkumar
requested changes
May 8, 2024
mahatoankitkumar
requested changes
May 9, 2024
Sauravcv98
force-pushed
the
create-experiment-for-default-config
branch
from
2ea68dd
to
99e8289
Compare
|
Does this PR solve #33? |
Sauravcv98
force-pushed
the
create-experiment-for-default-config
branch
from
99e8289
to
ba1443f
Compare
mahatoankitkumar
requested changes
May 17, 2024
crates/experimentation_platform/src/api/experiments/handlers.rs
Outdated
Show resolved
Hide resolved
Sauravcv98
force-pushed
the
create-experiment-for-default-config
branch
from
e52a93a
to
d2beb5c
Compare
pratikmishra356
requested changes
May 21, 2024
pratikmishra356
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We were not able to create experiments and conclude them for default config, that is without giving any contexts
Solution
Made contexts optional, if it's None then we accept it as default config
Environment variable changes
What ENVs need to be added or changed
Pre-deployment activity
DB schema has been changed for experiments table, made context as nullable before it was not null
Post-deployment activity
Things needed to be done after deploying this change (if any)
API changes
Possible Issues in the future
Describe any possible issues that could occur because of this change