New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of custom example #1280
base: main
Are you sure you want to change the base?
Addition of custom example #1280
Conversation
Signed-off-by: Abhijith Ganesh <g.abhijith14122003@gmail.com>
Hi, I think something went wrong with this PR. There are 419 files in the commit and some of them don't look like belonging to this PR. Could you check and only commit files that are relevant? |
Hi, |
Only add a single file each time |
Yeah but the example is for a custom chart, I have to add all these files, how else can I make a custom chart? |
You should not add unmodified files, such as dependency source code. Those should not be part of the chart (they're not part of k8ssandra/k8ssandra either) |
Got it, will make the changes and push. Thanks for the clarification |
Signed-off-by: Abhijith Ganesh <g.abhijith14122003@gmail.com>
…esh/k8ssandra into example-custom-chart
@burmanm I have made changes and it reduced to the YAML template files, they don't come as a part of the dependency(as far as I know), should they be there or should something be done about them? |
I was thinking that what we would get here is just an example values.yaml that provides for a certain type of configuration you wanted to exhibit? Is there a reason we want anything more than that? |
Well, the chart would need .helmignore, chart.yaml and values.yaml mandatorily. Other template files maybe removed but I am not sure about the effects it may have once we delete. |
Signed-off-by: Abhijith Ganesh g.abhijith14122003@gmail.com
What this PR does:
Adds an example of a custom chart
Which issue(s) this PR fixes:
Fixes #1279
Checklist