Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our code allows to install / uninstall kairosDB as Windows Service and guarantee normal stopping of
the service (even though hook event was not triggered).
There are 2 files install_windows_service.bat and uninstall_windows_service which are used for installing and uninstalling the service. The service is based on Apache Daemon. The Daemon itself is also included (please note that you have to replace files from amd64 folder if you use 64 bit AMD or Intel).
We've also reworked a little bit the Main class in order to have ability to launch this properly in different package (org.kairosdb.core.daemon). The old functionality stays the same, it's still possible to laucnh Kairosdb as a console app.
Please review our code if needed, hopefully it will be merged to one of the future releases.