Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Examples #113

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

EMChamp
Copy link

@EMChamp EMChamp commented Jul 21, 2018

Added a separate folder with Python examples.

Tried to stay true to the Pythonic way when there wasn't a direct 1 to 1 mapping (protected/private variables, duck-typing) to the concepts from PHP. Also included separate files for the different types of Design Patterns.

@zruzicka
Copy link

Hi @kamranahmedse and @EMChamp, I like these python examples too. Is this a preferred way how examples in different programming languages could be added or do you want to apply a bit different approach which would avoid repeating of pattern explanation text in Readme file?

Copy link

@diegogsann diegogsann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is too old, but.....

are all of your examples using pep8? i'd found some places without it.

i.e. final empty line; two lines between classes;

as a suggestion, will be better if you could use something like flake8.

@Kully
Copy link

Kully commented Apr 23, 2020

Is this a preferred way how examples in different programming languages could be added or do you want to apply a bit different approach which would avoid repeating of pattern explanation text in Readme file?

Just noticed you guys already are in the process of adding python examples. Nice!

I was suggesting in an issue I just posted (gonna take down cause duplicate) that what if the post was put into a webpage with HTML support.

This way, we could create a toggle button to swap between coding languages and sub-in different codeBlocks, keeping the explanations in tact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants