Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cassandra tls #5803

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

rxg8255
Copy link

@rxg8255 rxg8255 commented May 14, 2024

Provide a description of what has been changed

Checklist

Fixes #

Relates to #

@rxg8255 rxg8255 requested a review from a team as a code owner May 14, 2024 22:00
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! We have to remove the credentials during the scaler Close() to remove not used credentials. Kafka scaler is already doing it and you can use it as example: https://github.com/kedacore/keda/blob/main/pkg/scalers/kafka_scaler_test.go

We should try to unify the code to access files if it's possible

CHANGELOG.md Outdated Show resolved Hide resolved
pkg/scalers/cassandra_scaler.go Show resolved Hide resolved
Signed-off-by: Ranjith Gopal <ranjith.gopalreddy@7-11.com>
@rxg8255 rxg8255 reopened this May 27, 2024
Ranjith Gopal and others added 4 commits May 27, 2024 13:01
Signed-off-by: Ranjith Gopal <ranjith.gopalreddy@7-11.com>
Signed-off-by: Ranjith Gopal <ranjith.gopalreddy@7-11.com>
Signed-off-by: Ranjith Gopal <ranjith.gopalreddy@7-11.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants