Test Windows CI

[mamantoha]

This was just a test for Windows CI

Finished in 49.14 seconds
121 examples, 13 failures, 16 errors, 0 pending

[mamantoha]

to fix the check_ameba workflow go to Setting -> Actions -> General and check "Read and write permissions"

[sdogruyol]

Thanks a lot @mamantoha 👍 Could you please tell me why do we need the permissions for ameba

[mamantoha]

@sdogruyol I don't know why https://github.com/crystal-ameba/github-action requires write permissions

[sdogruyol]

@mamantoha that's already enabled, do I need to do anything else?

[mamantoha]

@sdogruyol I don't understand why check_ameba fails. It works fine on my fork.

[sdogruyol]

Just reran the workflow and it failed with the same error. Not sure what's wrong with permissions 🤷

[straight-shoota]

It would be great to get Windows support merged.
On the code side the only relevant change is Process.on_interrupt - and that is direly needed. Maybe this could be merged on its own if CI needs more time?

[straight-shoota]

This fails on Windows, not sure why. It works fine locally.
I would suggest to disable this spec on windows. Actually, it only needs to execute once - the expected result is the same on any runner (if: matrix.os == 'ubuntu-latest' && matrix.crystal == 'nightly')

[straight-shoota]

The action seems to be broken (ref https://github.com/kemalcr/kemal/actions/runs/5443532334/jobs/9900164974?pr=657). So better exclude that from this PR. It's not necesary for Windows support.

[HertzDevil]

The Kemal::StaticFileHandler specs are failing because of this part:

kemal/src/kemal/static_file_handler.cr

Lines 30 to 38 in c995a2a

	expanded_path = File.expand_path(request_path, "/")
	is_dir_path = if original_path.ends_with?('/') && !expanded_path.ends_with? '/'
	expanded_path = expanded_path + '/'
	true
	else
	expanded_path.ends_with? '/'
	end
	file_path = File.join(@public_dir, expanded_path)

Both @public_dir and expanded_path contain the drive name, so file_path becomes something like C:\...\C:\.... Replacing the first line with just expanded_path = request_path makes all specs pass. I have not dug far enough to understand if the File.expand_path call has any significance on other platforms.

[straight-shoota]

StaticFileHandler probably just needs to be aligned with stdlib's implementation.

[HertzDevil]

That part in stdlib is:

    request_path = Path.posix(request_path)
    expanded_path = request_path.expand("/")

    file_path = @public_dir.join(expanded_path.to_kind(Path::Kind.native))

[mamantoha]

Hi @HertzDevil @straight-shoota I don't have a Windows environment to test this build locally. Can someone else take over and continue working on this pull request? Thank you.

[Sija]

This should be reverted, I believe.