Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Average DQN implementation #206

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Average DQN implementation #206

wants to merge 4 commits into from

Conversation

rbauld
Copy link

@rbauld rbauld commented May 19, 2018

This is my attempt to implement averaged DQN, based on this paper: https://arxiv.org/pdf/1611.01929.pdf

By default with avg_dqn=1 It should just be regular DQN/DDQN. When avg_dqn> 1 it will average over previous models. So you gain some stability at the cost of some computation time.

In any case, let me know what you think, or what tests should be done. I have already ran the agent tests and the cart pole example, but I think more extensive testing may be needed.

Seemingly the testing branch is 6 months behind, so I guess everyone is just merging to master?

@RaphaelMeudec
Copy link
Contributor

Hi! Thanks for your contribution, tests are failing since a few days ago, I'll dig into it and then look at your implementation!

@RaphaelMeudec RaphaelMeudec self-assigned this May 25, 2018
@rbauld
Copy link
Author

rbauld commented May 29, 2018

I took a look at some of the errors on the travis CI build. They don't really seem related to any of the changes I have made.

Seems other pull requests have had a similar issue.

In any-case, the changes were not too drastic, but I thought they were worthwhile making, since I have found some benefit when using average DQN in particularly noisy environments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants