Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: #1722 Run out of memory #1724

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Anselmoo
Copy link
Contributor

Update utils.py and test by using break instead of raise

Which issue(s) does this Pull Request fix?

resolves #1722

Details of the Pull Request

According to discussion #1721, theraise will be replaced by break for running out of memory in the case of batch_size==1
.

Update utils.py and test by using `break` instead of `raise`
@codecov
Copy link

codecov bot commented May 14, 2022

Codecov Report

Merging #1724 (f477215) into master (c51da2d) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #1724   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           51        51           
  Lines         3411      3413    +2     
=========================================
+ Hits          3411      3413    +2     
Impacted Files Coverage Δ
autokeras/utils/utils.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c51da2d...f477215. Read the comment docs.

Copy link
Collaborator

@haifeng-jin haifeng-jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

If history is None, it should trigger this error. To your test, does it trigger it?
We can first add a if to check its None, return an empty dict.

Check for empty dict in Oracle.update_trial to return invalid status.

I can make the change if you prefer?

@Anselmoo
Copy link
Contributor Author

Thanks for the fix!

If history is None, it should trigger this error. To your test, does it trigger it? We can first add a if to check its None, return an empty dict.

Check for empty dict in Oracle.update_trial to return invalid status.

I can make the change if you prefer?

Will be the changes small, then I would prefer if you would do it because I have to first get into the code. Otherwise, I will take later a look.

@haifeng-jin
Copy link
Collaborator

@Anselmoo I will make the fix then, it may take some time. Thanks.

@haifeng-jin
Copy link
Collaborator

This is blocked by:
keras-team/keras-tuner#704

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resnet_v2-models can cause out of memory error
2 participants