Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve contributing.md #19115

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

Faisal-Alsrheed
Copy link
Contributor

@Faisal-Alsrheed Faisal-Alsrheed commented Jan 29, 2024

I've made small updates to CONTRIBUTING.md to improve clarity and ease for new contributors.

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f7401d4) 70.87% compared to head (8a95061) 79.97%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #19115      +/-   ##
==========================================
+ Coverage   70.87%   79.97%   +9.10%     
==========================================
  Files         356      340      -16     
  Lines       38113    35881    -2232     
  Branches     7418     7048     -370     
==========================================
+ Hits        27011    28696    +1685     
+ Misses       9567     5595    -3972     
- Partials     1535     1590      +55     
Flag Coverage Δ
keras 79.82% <ø> (+6.05%) ⬆️
keras-jax 62.64% <ø> (ø)
keras-numpy 57.13% <ø> (ø)
keras-tensorflow 64.75% <ø> (ø)
keras-torch 63.96% <ø> (?)
keras.applications ?
keras.applications-numpy ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Faisal-Alsrheed Faisal-Alsrheed marked this pull request as ready for review January 29, 2024 19:29
Copy link
Member

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@Faisal-Alsrheed
Copy link
Contributor Author

Done, @fchollet :)
Thank you for the feedback.

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jan 29, 2024
@fchollet fchollet merged commit 0aaacea into keras-team:master Jan 29, 2024
6 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase kokoro:force-run labels Jan 29, 2024
@Faisal-Alsrheed Faisal-Alsrheed deleted the improve_CONTRIBUTING.md branch April 2, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants