Implement default editor for editing current message #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a default editor option for interactive message editing, including necessary argument handling and a new `:edit` command.
|
Thanks for the contribution! Do you think we can use the EDITOR env variable instead? |
|
+1 on using the EDITOR env variable. First VISUAL, then EDITOR. If none of them are set, go for a default or tell the user to set either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seemed convenient to have the option to edit current message in an external editor - this change allows for user to specify an external editor and use ":e/:edit" in order to do so.
This is for certain cases where more robust text editors can add value to the experience.